fix(testutil): handle GetNamespaces errors in EnsureNamespace#66
Closed
Copilot wants to merge 5 commits into
Closed
fix(testutil): handle GetNamespaces errors in EnsureNamespace#66Copilot wants to merge 5 commits into
Copilot wants to merge 5 commits into
Conversation
- Add explicit handling for GetNamespaces errors with fallback logic - Handle "already exists" errors gracefully when creating namespaces - Add strings package import for error message checking - Improve comments to explain error handling strategy Co-authored-by: freeznet <1381618+freeznet@users.noreply.github.com>
- Add comprehensive comment explaining why string matching is used - Add "Conflict" to the list of error patterns to check - Clarify this is a best-effort approach for test utilities Co-authored-by: freeznet <1381618+freeznet@users.noreply.github.com>
- Convert error messages to lowercase for robust pattern matching - Add comment about using case-insensitive matching - Ensures error detection works regardless of message casing Co-authored-by: freeznet <1381618+freeznet@users.noreply.github.com>
- Run go fmt to ensure consistent formatting - Update comment patterns to reflect lowercase matching - Fix struct field alignment Co-authored-by: freeznet <1381618+freeznet@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on E2E testing implementation
fix(testutil): handle GetNamespaces errors in EnsureNamespace
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
EnsureNamespacefunction silently ignored errors fromGetNamespaces, masking connection/permission issues and potentially causing duplicate namespace creation attempts.Changes
Error flow restructure: Changed
if err == niltoif err != nilwith explicit handling. When namespace listing fails, proceed to creation (listing may fail due to permissions while creation succeeds). The subsequentCreateNamespacecall surfaces genuine errors.Idempotent creation: Detect "already exists" errors from
CreateNamespaceand treat as success. Uses case-insensitive string matching for multiple error patterns since Pulsar admin client lacks typed errors:Error context: Real errors now properly propagate with
fmt.Errorfwrapping.Before: Connection/permission errors during listing were ignored, errors from duplicate creation were returned.
After: Real errors surface appropriately, function is fully idempotent.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.